CLDR-17081 Fix PNF test data for ICU #3270
Conversation
|
Still draft for now, so just fyi |
| CLDRFile cldrFile = factory.make(locale, true); | ||
| CLDRFile cldrFile = | ||
| factory.make(locale, true, DraftStatus.contributed); // don't include | ||
| // draft=unconfirmed/provisional |
There was a problem hiding this comment.
I don't know what I'm looking at, but is DraftStatus.contributed a property of the whole file? What I was seeing in some files was that some person-name resources had their draft status set to "contributed" (or, actually, not mentioned at all), and others had their draft status set to "provisional" or "unconfirmed". Does this catch that?
There was a problem hiding this comment.
It sets the minimum bar for items to be included. So contributed means either contributed or approved (which is implicit if there is no draft value). That's the general bar we use for ICU, so this should get better results. cc @pedberg-icu
common/main/gl.xml
Outdated
| </personName> | ||
| <personName order="sorting" length="medium" usage="referring" formality="formal"> | ||
| <namePattern>{surname-core} {surname2}, {given} {given2-initial} {surname-prefix}</namePattern> | ||
| <namePattern alt="1">{surname-core} {surname2}, {given} {given2} {surname-prefix}</namePattern> | ||
| <namePattern alt="1">{surname-core}, {given} {given2} {surname-prefix}</namePattern> |
There was a problem hiding this comment.
Did you want this to be {given2} when the first entry has {given2-initial}?
There was a problem hiding this comment.
Missed this, will examine in 1/2 hour
There was a problem hiding this comment.
Got it (lined up all the others for comparison, too, so I wouldn't miss any others). Good catch.
|
Dang, forgot to rerun the GenerateTestData! Can you stamp again? |
macchiati
deleted the
CLDR-17081-Remove-PNF-testData-below-contributed
branch
CLDR-17081
This is not yet complete; it fixes some of the "inclusion of draft data" plus the stray superscript
ALLOW_MANY_COMMITS=true